feat: k6runner: improve error handling for k6 output #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
force-pushed
the
port-runner
branch
2 times, most recently
from
41eaa1f to
856e47e
Compare
An error occurred while trying to automatically change base from
dockerfile-chromium-alpine
to
main
November 26, 2024 14:09
nadiamoe
force-pushed
the
port-runner
branch
from
856e47e to
cb74f61
Compare
|
hello @roobre, thank you for your work! Do you have an estimate for when this might be merged? |
|
Hey @devtony15, I expect to finish testing this week, so hopefully it will be merged a few days later. As per Grafana policy we have stopped making releases due to the holiday season, so my expectation is for this to be released early January. |
|
@mem hey, could you review it please?) |
ka3de
approved these changes
Jan 23, 2025
ka3de
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1060
This pull requests brings a number of improvements to how the local k6 runner, mostly used in private probe context, handles errors from k6. Most prominently:
nil, err(understood as "k6 could not be run"), but rather a response with a textual representation of the error, and the k6 output. This still causes the test to be marked as failed, but the error is reported to Loki and thus made visible.Based on #1061 as I want CI/CD to be able to run.